use Maven CI friendly versions#3325
use Maven CI friendly versions#3325minijackson wants to merge 1 commit intoControlSystemStudio:masterfrom
Conversation
This enables downstream users to make their own versions, by specifying -Drevision=4.7.4-42-SNAPSHOT in the Maven command-line. This also should make the Maven release plugin unnecessary, since the version is specified in a central place. More information here: https://maven.apache.org/guides/mini/guide-maven-ci-friendly.html and here: https://stackoverflow.com/a/67012045
|
@shroffk @georgweiss , Katy |
|
@katysaintin, we use the release plugin to also push build artifacts to Maven Central. How does this PR affect that step? |
|
I will ask to @minijackson , test a release in his fork before. @minijackson could you test a release with this modification in order to check if there is no unexpected effect side ? Here are the command to perform a release : 2 - Perform the release |
|
I'm in training this week, so I'll probably won't have the time to check it until next week, but according to the StackOverflow answer, it should make the release plugin not needed anymore. But I don't know how you use the release plugin, so I'll need your help to figure out if that's the case. |
|
Things is that the release plugin works together with the sonatype staging plugin such that build artifacts are published to Maven Central. Consequently I am a bit concerned about removing the release plugin. |
|
I think the main sticking point here is to make sure that the version described as a property are handled by the maven release plugin. How do all the IDEs like this? |
4 participants
This is a proposition to centralize the Phoebus version in the root
pom.xml, in therevisionproperty. This is an official Maven workflow, specified here: https://maven.apache.org/guides/mini/guide-maven-ci-friendly.htmlThis enables downstream users to make their own versions, by specifying
-Drevision=4.7.4-42-SNAPSHOTin the Maven command-line.This also should make the Maven release plugin unnecessary, since the version is specified in a central place, according to: https://stackoverflow.com/a/67012045
Tested with the command
mvn package -DskipTests -Drevision=4.7.4-42-SNAPSHOT